skip ManyToOne properties in SetterOnlyMethodAnalyzer (#1838)

packages/DeadCode/src/Analyzer/SetterOnlyMethodAnalyzer.php

@@ -77,9 +77,10 @@ public function provideSetterOnlyPropertiesAndMethodsByType(): array
             // 1. setter only properties by class
             $assignOnlyPrivatePropertyNames = $this->classManipulator->getAssignOnlyPrivatePropertyNames($class);
 
-            // filter out ManyToOne entities
-            $manyToOnePropertyNames = $this->doctrineEntityManipulator->resolveManyToOnePropertyNames($class);
-            $assignOnlyPrivatePropertyNames = array_diff($assignOnlyPrivatePropertyNames, $manyToOnePropertyNames);
+            // filter out ManyToOne/OneToMany entities
+            $relationPropertyNames = $this->doctrineEntityManipulator->resolveRelationPropertyNames($class);
+            $assignOnlyPrivatePropertyNames = array_diff($assignOnlyPrivatePropertyNames, $relationPropertyNames);
+
             if ($assignOnlyPrivatePropertyNames) {
                 $this->propertiesAndMethodsToRemoveByType[$type]['properties'] = $assignOnlyPrivatePropertyNames;
             }

packages/DeadCode/src/Doctrine/DoctrineEntityManipulator.php

@@ -4,6 +4,7 @@
 
 use Nette\Utils\Strings;
 use PhpParser\Comment\Doc;
+use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\Property;
 use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
@@ -183,7 +184,7 @@ public function isNullableRelation(Property $property): bool
     /**
      * @return string[]
      */
-    public function resolveManyToOnePropertyNames(Class_ $class): array
+    public function resolveRelationPropertyNames(Class_ $class): array
     {
         $manyToOnePropertyNames = [];
 
@@ -192,7 +193,7 @@ public function resolveManyToOnePropertyNames(Class_ $class): array
                 continue;
             }
 
-            if (! $this->docBlockManipulator->hasTag($stmt, self::MANY_TO_ONE_ANNOTATION)) {
+            if (! $this->isRelationProperty($stmt)) {
                 continue;
             }
 
@@ -201,4 +202,15 @@ public function resolveManyToOnePropertyNames(Class_ $class): array
 
         return $manyToOnePropertyNames;
     }
+
+    private function isRelationProperty(Node $node): bool
+    {
+        foreach (self::RELATION_ANNOTATIONS as $relationAnnotation) {
+            if ($this->docBlockManipulator->hasTag($node, $relationAnnotation)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }