Parent constant visibility when it is declared in a super-superclass#1884
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Aug 21, 2019
scheb:const-parent-visibility-2
Merged
Parent constant visibility when it is declared in a super-superclass#1884TomasVotruba merged 1 commit intorectorphp:masterfrom scheb:const-parent-visibility-2
TomasVotruba merged 1 commit intorectorphp:masterfrom
scheb:const-parent-visibility-2
Conversation
Member
50 K php file? Not 50 k lines? Wow, how much loc is it? :D Thanks for trying it out, this is very important on real huge projects. So I'm happy Rector did good job - also thanks to your contributoins 👍 |
Contributor
Author
🙈 |
Member
|
That's huge 😮 |
TomasVotruba
added a commit
that referenced
this pull request
Mar 1, 2022
rectorphp/rector-src@10de06f [DeadCode] Skip RemoveUnusedVariableAssignRector on assign to dynamic variable (#1884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After my recent improvements on the
PrivatizeLocalClassConstantRector, I've executed it on our big PHP project. Found out that the parent constant visibility is not detected correctly, when the constant is declared in the parent's parent or futher up the class hierarchy. This PR fixes the issue.Worth mentioning: I've executed it on a project with 50k PHP files, did an almost perfect job. This issue was only a handful of cases. So 👍 for rector!