Skip to content

Move Jetbrains PhpStorm stubs into dev dependencies#1901

Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom
atierant:phpstorm-requirement
Aug 26, 2019
Merged

Move Jetbrains PhpStorm stubs into dev dependencies#1901
TomasVotruba merged 1 commit intorectorphp:masterfrom
atierant:phpstorm-requirement

Conversation

@atierant
Copy link
Copy Markdown

@atierant atierant commented Aug 26, 2019

closes #1899

@TomasVotruba
Copy link
Copy Markdown
Member

Thanks!

Could you add "closes x" to PR description, so it closes the issue automatically on merge and we don't have to do it manually later?
https://help.github.com/en/articles/closing-issues-using-keywords

@atierant
Copy link
Copy Markdown
Author

Done 🙂

@TomasVotruba
Copy link
Copy Markdown
Member

Let's 🚢 it!

@TomasVotruba TomasVotruba merged commit 9bc7a25 into rectorphp:master Aug 26, 2019
TomasVotruba added a commit that referenced this pull request Mar 3, 2022
rectorphp/rector-src@e2cc867 [PhpSpecToPHPUnit] Deprecate historical set, mostly for experimental in early days (#1901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DeadCode] Requiring phpstorm-stubs leads to Multiple definitions exist for class...

2 participants