[PhpDoc] Multiline test improvements#1989
Merged
TomasVotruba merged 5 commits intomasterfrom Sep 17, 2019
Merged
Conversation
TomasVotruba
commented
Sep 17, 2019
| } | ||
|
|
||
| return false; | ||
| } |
Member
Author
There was a problem hiding this comment.
@sashabeton I did a small code cleanup of your rule + making coding standard pass, in case you'd be intereseted.
Main take aways:
- use the most precise node possible -
ArrayItem - add
shouldSkipX()(hereshouldSkipArrayItem()) method to skip invalid nodes in standalone method - avoid
&$referenceif possible, they create very hard to solve bugs
TomasVotruba
force-pushed
the
fix-annot-edge-cases
branch
from
4b10bd5 to
2169f40
Compare
TomasVotruba
force-pushed
the
fix-annot-edge-cases
branch
from
2169f40 to
939f1db
Compare
TomasVotruba
added a commit
that referenced
this pull request
Apr 1, 2022
rectorphp/rector-src@759b7c8 Bump actions/checkout from 2 to 3 (#1989)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.