Code sample fixes#2014
Merged
TomasVotruba merged 3 commits intorectorphp:masterfrom Sep 22, 2019
HypeMC:code-sample-fixes
Merged
Code sample fixes#2014TomasVotruba merged 3 commits intorectorphp:masterfrom HypeMC:code-sample-fixes
TomasVotruba merged 3 commits intorectorphp:masterfrom
HypeMC:code-sample-fixes
Conversation
| ), | ||
| new CodeSample( | ||
| '$this->assertObjectHasAttribute("foo", $anything);', | ||
| '$this->assertFalse(isset($anything["foo"]), "message");', |
Member
There was a problem hiding this comment.
Why this change? Rule should end up with objectHasAttribute in the end
Contributor
Author
There was a problem hiding this comment.
@TomasVotruba The first CodeSample had two before codes, while the second two after codes, when it should be one before and one after per CodeSample:
Member
There was a problem hiding this comment.
Ah, I see, I didn't notice it's 2 code samples when reading on mobile phone. All right then 👍
Member
|
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Apr 15, 2022
rectorphp/rector-src@91b8573 [PHPStan] Set compatible with upcoming PHPStan 1.6.x with set NodeConnectingVisitor tags (#2014)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some typos in certain code samples so I fixed them. I also updated the docs.