Skip to content

Fix printing of tab-indented files#2027

Merged
TomasVotruba merged 1 commit intomasterfrom
indent-fix
Sep 25, 2019
Merged

Fix printing of tab-indented files#2027
TomasVotruba merged 1 commit intomasterfrom
indent-fix

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Sep 25, 2019

Closes #1964

Comment thread abz/SomeFile.php Outdated
@dereuromark
Copy link
Copy Markdown
Contributor

dereuromark commented Sep 25, 2019

I would also keep an inline comment inside a function to be sure that one is also covered.

@TomasVotruba
Copy link
Copy Markdown
Member Author

One step at a time

@TomasVotruba TomasVotruba force-pushed the indent-fix branch 3 times, most recently from b2b6dad to 7974de9 Compare September 25, 2019 12:05
@TomasVotruba TomasVotruba changed the title add test for #1964 Fix printing of tab-indented files Sep 25, 2019
Comment thread src/PhpParser/Printer/BetterStandardPrinter.php
@TomasVotruba TomasVotruba force-pushed the indent-fix branch 2 times, most recently from 96b7cfb to f5b2e78 Compare September 25, 2019 12:35
@TomasVotruba TomasVotruba merged commit 98c2d8c into master Sep 25, 2019
@TomasVotruba TomasVotruba deleted the indent-fix branch September 25, 2019 13:00
@dereuromark
Copy link
Copy Markdown
Contributor

Wow, awesome 🎉 Thanks a lot!

TomasVotruba added a commit that referenced this pull request Apr 8, 2022
rectorphp/rector-src@b12415b [TypeDeclaration] Skip default type value different with type assigned (#2027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whitespace indentation breaking

2 participants