Add conditional method renaming rector#2047
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Sep 30, 2019
Merged
Conversation
TomasVotruba
requested changes
Sep 26, 2019
Member
TomasVotruba
left a comment
TomasVotruba
left a comment
There was a problem hiding this comment.
Nice job! I've added few comments, mostly naming
Member
|
Please rebased on |
We have a few renames in CakePHP that are parameter dependent. This rector lets a method be renamed based on the first parameter value. I've only supported string values as that is the current requirements.
markstory
force-pushed
the
rename-method-on-param
branch
from
ec88392 to
018edbe
Compare
Member
|
Looks good to me, thanks 👍 |
TomasVotruba
approved these changes
Sep 30, 2019
TomasVotruba
added a commit
that referenced
this pull request
Apr 10, 2022
rectorphp/rector-src@0227d24 Merge InArrayAndArrayKeysToArrayKeyExistsRector to ArrayKeysAndInArrayToArrayKeyExistsRector with almost identical behavior (#2047)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a few renames in CakePHP that are parameter dependent. This rector lets a method be renamed based on the first parameter value. I've only supported string values as that is the current requirements.