Skip to content

Fixed the third argument in VarDumperTestTrait. #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 4, 2019
Merged

Fixed the third argument in VarDumperTestTrait. #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/AllRectorsOverview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5721,16 +5721,16 @@ Changes Process string argument to an array

- class: `Rector\Symfony\Rector\VarDumper\VarDumperTestTraitMethodArgsRector`

Adds new `$format` argument in `VarDumperTestTrait->assertDumpEquals()` in Validator in Symfony.
Adds a new `$filter` argument in `VarDumperTestTrait->assertDumpEquals()` and `VarDumperTestTrait->assertDumpMatchesFormat()` in Validator in Symfony.

```diff
-$varDumperTestTrait->assertDumpEquals($dump, $data, $mesage = "");
+$varDumperTestTrait->assertDumpEquals($dump, $data, $context = null, $mesage = "");
-$varDumperTestTrait->assertDumpEquals($dump, $data, $message = "");
+$varDumperTestTrait->assertDumpEquals($dump, $data, $filter = 0, $message = "");
```

```diff
-$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $mesage = "");
+$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $context = null, $mesage = "");
-$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $message = "");
+$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $filter = 0, $message = "");
```

<br>
Expand Down
12 changes: 6 additions & 6 deletions packages/Symfony/src/Rector/VarDumper/VarDumperTestTraitMethodArgsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ public function __construct(string $traitName = 'Symfony\Component\VarDumper\Tes
public function getDefinition(): RectorDefinition
{
return new RectorDefinition(
'Adds new `$format` argument in `VarDumperTestTrait->assertDumpEquals()` in Validator in Symfony.',
'Adds a new `$filter` argument in `VarDumperTestTrait->assertDumpEquals()` and `VarDumperTestTrait->assertDumpMatchesFormat()` in Validator in Symfony.',
[
new CodeSample(
'$varDumperTestTrait->assertDumpEquals($dump, $data, $mesage = "");',
'$varDumperTestTrait->assertDumpEquals($dump, $data, $context = null, $mesage = "");'
'$varDumperTestTrait->assertDumpEquals($dump, $data, $message = "");',
'$varDumperTestTrait->assertDumpEquals($dump, $data, $filter = 0, $message = "");'
),
new CodeSample(
'$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $mesage = "");',
'$varDumperTestTrait->assertDumpMatchesFormat($dump, $format, $context = null, $mesage = "");'
'$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $message = "");',
'$varDumperTestTrait->assertDumpMatchesFormat($dump, $data, $filter = 0, $message = "");'
),
]
);
Expand Down Expand Up @@ -69,7 +69,7 @@ public function refactor(Node $node): ?Node

if ($node->args[2]->value instanceof String_) {
$node->args[3] = $node->args[2];
$node->args[2] = $this->createArg($this->createNull());
$node->args[2] = $this->createArg(0);

return $node;
}
Expand Down
6 changes: 3 additions & 3 deletions ...Symfony/tests/Rector/VarDumper/VarDumperTestTraitMethodArgsRector/Fixture/fixture.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function varDumperTrait()
{
$trait = new ClassWithVarDumperTrait();
$trait->assertDumpEquals($dump, $data, 'Some message');
$trait->assertDumpMatchesFormat($dump, $format, 'Some message');
$trait->assertDumpMatchesFormat($dump, $data, 'Some message');
}

?>
Expand All @@ -18,8 +18,8 @@ use Rector\Symfony\Tests\Rector\VarDumper\VarDumperTestTraitMethodArgsRector\Sou
function varDumperTrait()
{
$trait = new ClassWithVarDumperTrait();
$trait->assertDumpEquals($dump, $data, null, 'Some message');
$trait->assertDumpMatchesFormat($dump, $format, null, 'Some message');
$trait->assertDumpEquals($dump, $data, 0, 'Some message');
$trait->assertDumpMatchesFormat($dump, $data, 0, 'Some message');
}

?>