Skip to content

Add failing test: StringifyStrNeedlesRector adds (string) to a method call that returns a string anyway #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Oct 4, 2019
Merged

Add failing test: StringifyStrNeedlesRector adds (string) to a method call that returns a string anyway #2081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd1a1ad
Add failing test: it adds (string) to a method call that returns a st…
gnutix Oct 2, 2019
0144b78
Put all the test code inside the class' methods.
gnutix Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...Php73/tests/Rector/FuncCall/StringifyStrNeedlesRector/Fixture/skip_already_string.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Rector\Php73\Tests\Rector\FuncCall\StringifyStrNeedlesRector\Fixture;

final class SkipAlreadyString
{
public function getNeedle(): string
{
return 'needle';
}

public function __invoke()
{
return strpos('needle', (new SkipAlreadyString)->getNeedle());
}
}
1 change: 1 addition & 0 deletions ...s/Php73/tests/Rector/FuncCall/StringifyStrNeedlesRector/StringifyStrNeedlesRectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public function provideDataForTest(): Iterator
yield [__DIR__ . '/Fixture/fixture.php.inc'];
yield [__DIR__ . '/Fixture/trait.php.inc'];
yield [__DIR__ . '/Fixture/skip_twice.php.inc'];
yield [__DIR__ . '/Fixture/skip_already_string.php.inc'];
}

protected function getRectorClass(): string
Expand Down