Fixing 'return new static()' not being covered by MakeInheritedMethodVisibilitySameAsParentRector#2082
Merged
TomasVotruba merged 6 commits intorectorphp:masterfrom Oct 4, 2019
Conversation
…r : 'return new self();' works, 'return new static();' does not.
Member
|
Please always create a new fixture file, so the fix is more clear and tests as small & readable as possible Could you make fix with it? |
Contributor
Author
|
Fixed. |
Contributor
Author
|
And if you don't mind, I felt like fixing the implemention, while I was at it. :) |
gnutix
changed the title
TomasVotruba
requested changes
Oct 3, 2019
TomasVotruba
approved these changes
Oct 4, 2019
Member
|
Thank you 👍 |
TomasVotruba
deleted the
MakeInheritedMethodVisibilitySameAsParentRector/adding-testcase
branch
TomasVotruba
added a commit
that referenced
this pull request
Apr 16, 2022
rectorphp/rector-src@6cb95c1 Update rector_rules_overview.md (#2082)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return new self();was correctly handled, whilereturn new static();was not. Now both are.Fixes #2057