Add FunctionCallToConstantRector#2100
Merged
TomasVotruba merged 4 commits intorectorphp:masterfrom Oct 4, 2019
Merged
Conversation
TomasVotruba
reviewed
Oct 4, 2019
TomasVotruba
reviewed
Oct 4, 2019
| return null; | ||
| } | ||
|
|
||
| private function refactorVersionCompare(Node $node): ?Node |
Member
There was a problem hiding this comment.
Suggested change
| private function refactorVersionCompare(Node $node): ?Node | |
| private function refactorVersionCompare(FuncCall $funcCall): ?BinaryOp |
Here you can use more precise types
TomasVotruba
requested changes
Oct 4, 2019
Member
TomasVotruba
left a comment
TomasVotruba
left a comment
There was a problem hiding this comment.
I checked the implementation, very clear to read the code 👍
Just one detail about split to 1 specific + 1 generic rule
Comment on lines
+13
to
+27
| ?> | ||
| ----- | ||
| <?php | ||
|
|
||
| namespace Rector\CodingStyle\Tests\Rector\FuncCall\FunctionCallToConstantRector\Fixture; | ||
|
|
||
| class SkipVersionCompareClass | ||
| { | ||
| public function run() | ||
| { | ||
| version_compare($this->version, '5.3.0', '<'); | ||
| } | ||
| } | ||
|
|
||
| ?> |
Member
There was a problem hiding this comment.
This section can be removed in "skip" fixture, as when A = B, only A is needed
|
|
||
| 50300 < PHP_VERSION_ID; | ||
| 50300 > PHP_VERSION_ID; | ||
| 50300 === PHP_VERSION_ID; |
TomasVotruba
approved these changes
Oct 4, 2019
Member
|
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Apr 20, 2022
rectorphp/rector-src@de95ab6 [DX] Add sets() to RectorConfig upgrade rule (#2100)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2008