Skip to content

[StrictCodeQuality] Add freshly created node support to var inline assert#2122

Merged
TomasVotruba merged 2 commits intomasterfrom
var-assert
Oct 8, 2019
Merged

[StrictCodeQuality] Add freshly created node support to var inline assert#2122
TomasVotruba merged 2 commits intomasterfrom
var-assert

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Oct 8, 2019 •
edited
Loading

Closes #2118

-/** @var int $value */
 $int = $some->get();
+assert(is_int($value));

@TomasVotruba TomasVotruba merged commit cf63ed7 into master Oct 8, 2019
@TomasVotruba TomasVotruba deleted the var-assert branch October 8, 2019 18:08
TomasVotruba added a commit that referenced this pull request Apr 22, 2022
@TomasVotruba
Updated Rector to commit 75fccc5
af205b1 
rectorphp/rector-src@75fccc5 [Php71] Remove PropertyFetchAnalyzer::isFilledByConstructParam (#2122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VarInlineAnnotationToAssertRector will almost always end up with failed assertions.

1 participant

@TomasVotruba