[Symfony] Add ConsoleExecuteReturnIntRector

[keulinho]

Fixes: #2119

[TomasVotruba]

Do you plan to handle no return in execute() as well?

E.g.

 public function execute($input, $output)
 {
     $output->write('hi');
+    return 0;
 }

[keulinho]

That should already be covered.

[TomasVotruba]

I mean this process:

if ($staticType instanceof MixedType) {
    // no idea → skip
}

if ($staticType instanceof IntegerType) {
   // already done → skip
}

// change the rest propperly

[TomasVotruba]

Related Symfony PR: symfony/symfony#33775

[TomasVotruba]

Btw, only numeric values are converted to int:
https://github.com/symfony/symfony/pull/33775/files#diff-8e80595663798837db1b033187835535R262

It seems like anything else will return 0:

-return 'hey';
+return 0;

-return '13';
+return 13;

[keulinho]

So what do you suggest?
instead of always casting the return value we could use something like:

- return $this->doSomething();
+ $result = $this->doSomething();
+ is_numeric($result) ? return (int) $result : return 0;

[TomasVotruba]

I suggest to change the value only if know what is returned, but that's just an detail.

But moreover, we should merge this PR as it is now, as there is lot of opened work. So next step is just small iteration

[TomasVotruba]

Could you just make CI pass? It's ready then

[keulinho]

👍
CI did pass, merging is blocked because you've requested changes ;)

[TomasVotruba]

Few moments I saw if fail, probably miss click.
All right then :)