Skip to content

[PHPUnit] Add RemoveDataProviderTestPrefixRector#2144

Merged
TomasVotruba merged 1 commit intomasterfrom
phpunit-provider
Oct 12, 2019
Merged

[PHPUnit] Add RemoveDataProviderTestPrefixRector#2144
TomasVotruba merged 1 commit intomasterfrom
phpunit-provider

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Oct 11, 2019

Closes #2136

The Change

  <?php
  
  namespace App\Tests;
  
  class SomeClass extends \PHPUnit\Framework\TestCase
  {
      /**
-      * @dataProvider testProvideData()
+      * @dataProvider provideData()
       */
      public function test()
      {
          $nothing = 5;
      }
  
-     public function testProvideData()
+     public function provideData()
      {
          return ['123'];
      }
  }

Made with: https://www.quickdiff.com/

@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented Oct 11, 2019

cc @DaveLiddament Feedback appreciated, this should be simple one 😉

@TomasVotruba TomasVotruba force-pushed the phpunit-provider branch 3 times, most recently from 3a5c927 to 011485e Compare October 11, 2019 11:02
@TomasVotruba TomasVotruba merged commit 4fd1cde into master Oct 12, 2019
@TomasVotruba TomasVotruba deleted the phpunit-provider branch October 15, 2019 13:57
TomasVotruba added a commit that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PHPUnit 7.0] provider function name cannot start with "test" anymore

1 participant