Merged
Conversation
This test shows the false positive for `hyphen + shorthand` combination outside a character class which should not be escaped.
This patch fixes this issue. But I suspect that there will be more edge cases which will not be fixed with this small patch. Perhaps it will be better to assure, that the escaping will only executed on hyphen in character classes.
Member
|
Thank you for the fix. |
TomasVotruba
added a commit
that referenced
this pull request
Apr 26, 2022
rectorphp/rector-src@ae45be1 [DX] Add note warning about using old config (#2174)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes this issue. But I suspect that there will be more edge cases which will not be fixed with this small patch. Perhaps it will be better to assure, that the escaping will only executed on hyphen in character classes.