Previous statement rewrite#2207
Merged
TomasVotruba merged 10 commits intorectorphp:masterfrom Nov 1, 2019
Merged
Conversation
Member
|
I look forward to review this! Let me know when CI passes |
TomasVotruba
approved these changes
Nov 1, 2019
Member
|
Looks good, thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current/Previous expression did not work as expected.
It only took \PhpParser\Node\Stmt\Expression as boundary leading to issues when other instances of \PhpParser\Node\Stmt where previous.
It also turned out that the current implementation of correctPregMatchType was working by incident. But would break if any random statement was put on packages/Php71/tests/Rector/FuncCall/CountOnNullRector/Fixture/preg_match_array.php.inc:9