Add AbstractController as base class if no one exists#2223
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Oct 31, 2019
Merged
Add AbstractController as base class if no one exists#2223TomasVotruba merged 2 commits intorectorphp:masterfrom
TomasVotruba merged 2 commits intorectorphp:masterfrom
Conversation
Member
TomasVotruba
left a comment
TomasVotruba
left a comment
There was a problem hiding this comment.
Very good first draft, wow!
Just one more check and it's ready
Contributor
Author
|
There is one more thing I thought about. What if the controller is extending a class which is not based on AbstractController, like: class MyController extends DefaultController {
}
class DefaultController {
}In this case, the render method would be added, but still failing as its missing. |
Member
|
Agreed. Should we skip such case? |
Contributor
Author
|
Exactly, I think it is something which can be skipped for now. Can be fixed when its needed :) |
Member
|
Thank you |
TomasVotruba
added a commit
that referenced
this pull request
May 4, 2022
rectorphp/rector-src@6327904 [CodingStyle] Skip override parent method on UnSpreadOperatorRector (#2223)
TomasVotruba
added a commit
that referenced
this pull request
May 4, 2022
rectorphp/rector-src@6327904 [CodingStyle] Skip override parent method on UnSpreadOperatorRector (#2223)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first draft to fix #2215.
It seems to work, but I get an error from PHPStan which I don't understand.
Maybe you can help me with that?