Skip to content

make screen generate file by default #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Nov 1, 2019
Merged

make screen generate file by default #2231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions src/Console/Command/ScreenFileCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
use Rector\PhpParser\Printer\BetterStandardPrinter;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symplify\PackageBuilder\Console\Command\CommandNaming;
Expand All @@ -41,11 +40,6 @@ final class ScreenFileCommand extends AbstractCommand
*/
private const FILE_ARGUMENT = 'file';

/**
* @var string
*/
private const OUTPUT_OPTION = 'output';

/**
* @var SymfonyStyle
*/
Expand Down Expand Up @@ -107,7 +101,6 @@ protected function configure(): void
$this->setDescription('Load file and print nodes meta data - super helpful to learn to build rules');

$this->addArgument(self::FILE_ARGUMENT, InputArgument::REQUIRED, 'Path to file to be screened');
$this->addOption(self::OUTPUT_OPTION, 'o', InputOption::VALUE_REQUIRED, 'Path to print decorated file into');
}

protected function execute(InputInterface $input, OutputInterface $output): int
Expand All @@ -123,7 +116,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$this->decorateNodes($nodes);

// 4. print decorated nodes to output/file
$this->outputDecoratedFileContent($input, $nodes);
$this->outputDecoratedFileContent($nodes, $smartFileInfo);

return Shell::CODE_SUCCESS;
}
Expand Down Expand Up @@ -155,16 +148,14 @@ private function decorateNodes(array $nodes): void
/**
* @param Node[] $nodes
*/
private function outputDecoratedFileContent(InputInterface $input, array $nodes): void
private function outputDecoratedFileContent(array $nodes, SmartFileInfo $fileInfo): void
{
$decoratedFileContent = '<?php' . PHP_EOL . $this->betterStandardPrinter->prettyPrint($nodes);

$outputOption = (string) $input->getOption(self::OUTPUT_OPTION);
if ($outputOption) {
FileSystem::write($outputOption, $decoratedFileContent);
} else {
$this->symfonyStyle->writeln($decoratedFileContent);
}
$outputFileName = 'rector_vision_' . $fileInfo->getFilename();
FileSystem::write($outputFileName, $decoratedFileContent);

$this->symfonyStyle->writeln(sprintf('See: %s', $outputFileName));
}

/**
Expand Down