Skip to content

Also remove assignment if the value of the assignment is different#2233

Merged
TomasVotruba merged 4 commits intorectorphp:masterfrom
jeroensmit:DoubleAssignmentDifferentValue
Nov 2, 2019
Merged

Also remove assignment if the value of the assignment is different#2233
TomasVotruba merged 4 commits intorectorphp:masterfrom
jeroensmit:DoubleAssignmentDifferentValue

Conversation

@jeroensmit
Copy link
Copy Markdown
Contributor

No description provided.

@TomasVotruba
Copy link
Copy Markdown
Member

CI needs fix.

Tip for better development: run Rector with the rule you're changing on itself:

bin/rector p src packages --set dead-code --dry-run

It would quickly show false positives of your implementation

@TomasVotruba
Copy link
Copy Markdown
Member

I've merge your other PR, please rebase on master

@jeroensmit jeroensmit force-pushed the DoubleAssignmentDifferentValue branch from 4fd773b to b7a1f13 Compare November 2, 2019 16:08
@TomasVotruba TomasVotruba merged commit ef7943d into rectorphp:master Nov 2, 2019
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you 👍

TomasVotruba added a commit that referenced this pull request May 5, 2022
rectorphp/rector-src@a19b983 [DeadCode] Add StaticPropertyFetch removal support on RemoveUnusedPrivatePropertyRector (#2233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants