Skip to content

[CodeQuality] Add property assigns to RemoveAlwaysTrueConditionSetInConstructorRector#2246

Merged
TomasVotruba merged 2 commits intomasterfrom
fix-always-true
Nov 4, 2019
Merged

[CodeQuality] Add property assigns to RemoveAlwaysTrueConditionSetInConstructorRector#2246
TomasVotruba merged 2 commits intomasterfrom
fix-always-true

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cover public property as well - skip it as it can contain anything

@TomasVotruba TomasVotruba force-pushed the fix-always-true branch 2 times, most recently from e6b23f5 to 64dddcb Compare November 4, 2019 16:11
@TomasVotruba TomasVotruba changed the title [WIP] [CodeQuality] Add property assigns to RemoveAlwaysTrueConditionSetInConstructorRector [CodeQuality] Add property assigns to RemoveAlwaysTrueConditionSetInConstructorRector Nov 4, 2019
@TomasVotruba TomasVotruba merged commit 3ff7951 into master Nov 4, 2019
@TomasVotruba TomasVotruba deleted the fix-always-true branch November 4, 2019 17:06
TomasVotruba added a commit that referenced this pull request May 7, 2022
rectorphp/rector-src@26cad67 [CodingStyle] Clean up getParents() call on MakeInheritedMethodVisibilitySameAsParentRector (#2246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant