RemoveSetterOnlyPropertyAndMethodRector and UnusedPrivatePropertyRector fixes#2293
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Nov 8, 2019
Merged
Conversation
…ertyRector fixes.
Member
|
Thank you! 👍 New test fixtures makes this quite easy to review |
TomasVotruba
approved these changes
Nov 8, 2019
TomasVotruba
added a commit
that referenced
this pull request
May 11, 2022
rectorphp/rector-src@1026ede Remove requires from tests, as all tests run on PHP 8.1 (#2293)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once again got a little out of hand.
Bugs fixed:
Both rectors now share the same logic.
The old way RemoveSetterOnlyPropertyAndMethodRector turned out to be rather slow on our codebase (30x slower than all other rectors). This in now fixed.