Conversation
|
What's the reason behind this? |
|
Is easier to spot which example file is causing exceptions PHPunit output: before change: after change: |
|
How would you re-run only the specific file without re-typing filename? E.g. there are many files like |
|
the complete name filter filters on looks something like: The filter option works as an regex so you could do: vendor/bin/phpunit --filter ConstructorInjectionToAction.*duplicateor vendor/bin/phpunit --filter ConstructorInjectionToAction --filter duplicatea part of the file names suffices (doesn't need to be from te start) |
|
How would you compare it to |
|
Having both options would be something I'd merge: Rector\DeadCode\Tests\Rector\Class_\RemoveSetterOnlyPropertyAndMethodCallRector\
...RemoveSetterOnlyPropertyAndMethodCallRectorTest::test with
...data set #0 - "deal_with_property_fetches.php.inc" |
|
Just what I was thinking. Sadly the best thing I can reach is this:
If you find that sufficient I'll update the pullrequest. |
|
Yes, that's what I meant :) go for it |
| foreach ($fileInfos as $fileInfo) { | ||
| yield $fileInfo->getFilename() => [$fileInfo->getPathName()]; | ||
| yield "{$key} " . $fileInfo->getFilename() => [$fileInfo->getPathName()]; | ||
| $key++; |
There was a problem hiding this comment.
Why not use key of this foreach?
There was a problem hiding this comment.
key contains the filepath
There was a problem hiding this comment.
Ah, I used FinderSanitizer to remove this WTF
Ok
jeroensmit
force-pushed
the
testsetnaming
branch
from
dfdcfcd to
a836c4b
Compare
|
Thank you |
|
I'm finally testing it an it breaks filtering by provider key vendor/bin/phpunit packages/.../RectorTest.php --filter test#1 |
|
Sorry for taking a while. Hopefully you managed by now, if not the solution was using @ instead of # |
rectorphp/rector-src@e88903f [Core] Improve UnreachableStmtAnalyzer: verify itself by recursive call (#2300)
2 participants
No description provided.