Skip to content

Fixed issue with sed command:#2318

Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom
jeroensmit:mac-os-sed-command-fixes
Nov 14, 2019
Merged

Fixed issue with sed command:#2318
TomasVotruba merged 2 commits intorectorphp:masterfrom
jeroensmit:mac-os-sed-command-fixes

Conversation

@jeroensmit
Copy link
Copy Markdown
Contributor

on macOs the -E option was taken as the argument of the -i option causing backups to be made with the addional extension -E.
also the backslash of the \s needed additional escaping

on macOs the -E option was taken as the argument of the -i option causing backups to be made with the addional extension -E.
also the backslash of the \s needed additional escaping
@TomasVotruba TomasVotruba merged commit 544561f into rectorphp:master Nov 14, 2019
#!/usr/bin/env bash
# trailing whitespaces
sed -i -E 's#\s+$##g' config/set/*/*.yaml docs/*.md README.md
sed -i '' -E 's#\\s+$##g' config/set/*/*.yaml docs/*.md README.md
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now keeps failing on Linux :/

Travis didn't fail, because the check was not added there. I've added it:
#2322

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for unix and macOs both is #2323

TomasVotruba added a commit that referenced this pull request May 15, 2022
rectorphp/rector-src@0686f43 [PHPStan] Enable symplify-rules.neon (#2318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants