Add diff based execution#2347
Merged
TomasVotruba merged 3 commits intorectorphp:masterfrom Nov 23, 2019
Merged
Conversation
Member
|
Rebase on |
EmanueleMinotto
force-pushed
the
diff-only-execution
branch
from
7237a90 to
3df1647
Compare
EmanueleMinotto
force-pushed
the
diff-only-execution
branch
2 times, most recently
from
5183a45 to
d677ae4
Compare
Contributor
Author
|
@TomasVotruba done |
Member
|
Thank, can you update Right above: https://github.com/rectorphp/rector#3-steps-to-create-your-own-rector |
EmanueleMinotto
force-pushed
the
diff-only-execution
branch
from
dc7b821 to
7286203
Compare
|
|
||
| Execution can be limited to changed files using the `process` option `--must-match-git-diff`. | ||
| This option will filter the files included by the configuration, creating an intersection with the files listed in `git diff`. | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| > ```bash | |
| > vendor/bin/rector process src --must-match-git-diff | |
| > ``` |
Nice 👍
One last thing. I always copy-paste commands from READMEs, as want to try them asap. This should do
Member
There was a problem hiding this comment.
I'll handle that locally, let's merge it
TomasVotruba
approved these changes
Nov 23, 2019
|
|
||
| Execution can be limited to changed files using the `process` option `--must-match-git-diff`. | ||
| This option will filter the files included by the configuration, creating an intersection with the files listed in `git diff`. | ||
|
|
Member
There was a problem hiding this comment.
I'll handle that locally, let's merge it
TomasVotruba
added a commit
that referenced
this pull request
May 22, 2022
rectorphp/rector-src@8fbc658 [Core][Naming] Move collecting param names method to FunctionLikeManipulator (#2347)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the option
--must-match-git-diffto the process command, this is useful for both local and CI execution.It should be compatible with the rest of the configuration because creates an intersection with the
git diffoutput.