Skip to content

return false on MethodCall name to prevent expr errors #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Dec 5, 2019
Merged

return false on MethodCall name to prevent expr errors #2400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62616a8
return false on MethodCall name to prevent expr errors
TomasVotruba Dec 5, 2019
4df171d
fixup! return false on MethodCall name to prevent expr errors
TomasVotruba Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions src/PhpParser/Node/Resolver/NameResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
use PhpParser\Node\Stmt\Property;
use PhpParser\Node\Stmt\Trait_;
use PhpParser\Node\Stmt\Use_;
use Rector\Exception\ShouldNotHappenException;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\SmartFileSystem\SmartFileInfo;

final class NameResolver
{
Expand All @@ -46,19 +44,8 @@ public function isNames(Node $node, array $names): bool
public function isName(Node $node, string $name): bool
{
if ($node instanceof MethodCall) {
$debugBacktrace = debug_backtrace();

$previousCaller = $debugBacktrace[1];
$fileInfo = new SmartFileInfo($previousCaller['file']);
$location = $fileInfo->getRelativeFilePathFromDirectory(getcwd()) . ':' . $previousCaller['line'];

throw new ShouldNotHappenException(sprintf(
'Cannot get name on "%s" node. Use "$node->name" or check if "$node->class" is of "%s" type.%sCalled in: %s',
MethodCall::class,
Name::class,
PHP_EOL,
$location
));
// method call cannot have a name, only the variable or method name
return false;
}

$resolvedName = $this->getName($node);
Expand Down