Skip to content

fix rename method call #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Dec 22, 2019
Merged

fix rename method call #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/Renaming/src/Rector/MethodCall/RenameMethodCallRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function getNodeTypes(): array
public function refactor(Node $node): ?Node
{
foreach ($this->oldToNewMethodsByClass as $type => $oldToNewMethods) {
if (! $this->isObjectType($node, $type)) {
if (! $this->isObjectType($node->var, $type)) {
continue;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Rector/AbstractRector/NodeTypeResolverTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ protected function isMethodStaticCallOrClassMethodObjectType(Node $node, string
}

// method call is variable return
return $this->isObjectType($node, $type);
return $this->isObjectType($node->var, $type);
}

if ($node instanceof StaticCall) {
Expand Down