Skip to content

Add ScanFatalErrors command#2476

Merged
TomasVotruba merged 3 commits intomasterfrom
scan-fatals
Dec 24, 2019
Merged

Add ScanFatalErrors command#2476
TomasVotruba merged 3 commits intomasterfrom
scan-fatals

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Dec 24, 2019

Closes #2388

Useful for creating param/return type completion based on your specific code

vendor/bin/rector scan-fatal-errors src

Then run Rector to complete param/return types:

vendor/bin/rector process src --config rector-types.yaml

@TomasVotruba TomasVotruba force-pushed the scan-fatals branch 2 times, most recently from f7616c6 to ca862ff Compare December 24, 2019 12:43
@TomasVotruba TomasVotruba changed the title [WIP] Add ScanFatalErrors command Add ScanFatalErrors command Dec 24, 2019
@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented Dec 24, 2019

It requires more work to detect multiple fatal errors in single file.
So far it support errors on invalid parent type (unlimited) and invalid return type (single per file) - in violation with parent one.


Now as a part of the build:

https://travis-ci.org/rectorphp/rector/jobs/629125978#L406

@TomasVotruba TomasVotruba merged commit 67c4f76 into master Dec 24, 2019
@TomasVotruba TomasVotruba deleted the scan-fatals branch December 24, 2019 15:37
TomasVotruba added a commit that referenced this pull request Jun 11, 2022
rectorphp/rector-src@9679ed6 [DeadCode] Skip using coealesce assign operator on return on RemoveUnusedPrivatePropertyRector (#2476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NFR] Scan for fatal errors

2 participants