Do not suggest typed property when defined in vendored parent#2509
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Dec 27, 2019
Merged
Do not suggest typed property when defined in vendored parent#2509TomasVotruba merged 1 commit intorectorphp:masterfrom
TomasVotruba merged 1 commit intorectorphp:masterfrom
Conversation
ruudk
force-pushed
the
ignore-vendor-typed-property
branch
from
f3cb937 to
1815ded
Compare
Contributor
Author
|
How come the PHP74 tests are executed on PHP 7.2? Shouldn't they be excluded? |
ruudk
force-pushed
the
ignore-vendor-typed-property
branch
from
1815ded to
c659151
Compare
Member
There is no limit on the class, so To skip the test class even running, you need to add this above it: /**
* @requires PHP >= 7.4
*/ |
ruudk
force-pushed
the
ignore-vendor-typed-property
branch
from
c659151 to
dd0f224
Compare
Contributor
Author
|
Applied all feedback and added |
When the property is defined in vendored code, it doesn't make sense to suggest typed properties on classes that extend from it.
ruudk
force-pushed
the
ignore-vendor-typed-property
branch
from
dd0f224 to
433f929
Compare
TomasVotruba
approved these changes
Dec 27, 2019
Member
|
Thank you 👍 |
Contributor
Author
|
@TomasVotruba Could you please tag a new release including this fix? 🙏 |
Member
TomasVotruba
added a commit
that referenced
this pull request
Jun 16, 2022
rectorphp/rector-src@fc90ad2 [TypeDeclaration] Skip implements mixed, and already has typed return on AddReturnTypeDeclarationRector (#2509)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the property is defined in vendored code, it doesn't make sense to suggest typed properties on classes that extend from it.
Fixes #2506