Merged
Conversation
Contributor
|
Looks good! Just perhaps |
Member
Author
|
@enumag Good point, updated + test included |
enumag
approved these changes
Dec 30, 2019
TomasVotruba
force-pushed
the
generic
branch
from
1ebd156 to
795b54a
Compare
TomasVotruba
added a commit
that referenced
this pull request
Jun 19, 2022
rectorphp/rector-src@e22941a [PHP 7.4] Skip default expr type on property, if there is mixed assign (#2534)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@enumag Apperently, only edge-case is generic
array, that needs to be converted to array. It's treated as object without that, e.g. FQN by default\arrayand other problems.Maybe there is more space for improvement. What do you think?