[Php71] Add failing test case for CountOnNullRector#2538
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Jan 3, 2020
Merged
Conversation
gnutix
force-pushed
the
CountOnNullRector/should-skip-remote-property-if-countable
branch
from
cbc04b4 to
856afe1
Compare
Member
|
Could you look at fix while at it? |
Member
|
This one is more tricky then it meets the eye |
TomasVotruba
deleted the
CountOnNullRector/should-skip-remote-property-if-countable
branch
Contributor
Author
|
Seemed tricky indeed, as the local variable test passes but not the "remote" (reference?) one. |
Member
|
Not sure what you mean. Could you send test case? |
Contributor
Author
|
Forget it, I hadn't seen yet that you had already made a PR to fix it :) I'll try it out next week. Thanks! |
Member
|
Ah :) |
TomasVotruba
added a commit
that referenced
this pull request
Jun 20, 2022
rectorphp/rector-src@945889c Forbid PHPStan ClassMethod to avoid false type miss-matches (#2538)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed to create a failing test for #2474