[MinimalScope] Add ChangeLocalPropertyToVariableRector

[TomasVotruba]

Closes #1900

[staabm]

Wouldnt the rector fail when the method e.g. looks like

public function run()
     {
         If ($this->count == 5) {
           $this->count = 10;
           return $this->count;
         }
         $this->count = 5;
         return $this->count;
     }

[TomasVotruba]

Why should it fail?

[staabm]

I guess the logic will change because of the rector.

In case it gets transformed into

public function run()
     {
         If ($count == 5) {
           $count = 10;
           return $count;
         }
         $count = 5;
         return $count;
     }

The method will return different values when invoked 2 times in a row

[TomasVotruba]

The method will return different values when invoked 2 times in a row

I see. That's what I was missing.

How would you change the rule to make it work in these cases?

[staabm]

I guess it could work when you made sure that there is only a single property-write (or zero)

[TomasVotruba]

That sounds clear, I'll add fixture for that. Thanks for spotting this 👍

[TomasVotruba]

#2563 (comment)

[TomasVotruba]

It might needs full new service to analyze scope in the future. Let's see how it handles reality now