Skip to content

Try pcov for code coverage#2581

Merged
TomasVotruba merged 4 commits intorectorphp:masterfrom
staabm:patch-2
Jan 6, 2020
Merged

Try pcov for code coverage#2581
TomasVotruba merged 4 commits intorectorphp:masterfrom
staabm:patch-2

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Jan 6, 2020

Comment thread .travis.yml Outdated
@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 6, 2020

What do you think about moving the simple checks to GithubAction so overall build-time can be reduced? (Less sequential tasks)

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jan 6, 2020

What do you think about moving the simple checks to GithubAction so overall build-time can be reduced? (Less sequential tasks)

I haven't used them yet. PR prototype would help

Comment thread .travis.yml Outdated
@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 6, 2020

Remaining failures seem unrelated

@TomasVotruba
Copy link
Copy Markdown
Member

Indeed. Thanks 👍

@TomasVotruba TomasVotruba merged commit a024899 into rectorphp:master Jan 6, 2020
@staabm staabm deleted the patch-2 branch January 6, 2020 13:09
@TomasVotruba
Copy link
Copy Markdown
Member

The coverage just dropped by 4 %

https://coveralls.io/github/rectorphp/rector?branch=master

image

That's way too much for 1 min improvements on parallel Travis run.

We'll need to revert

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 6, 2020

Imo the coverage did not actually change but pcov treats some details differenz and therefore leads to a different number

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jan 6, 2020

The number changed for much worse. If that would be ~0,5 % than it's ok.
But this might be seriously missleading. Someone might try to fix coverage locally for something that's already covered. 4 % is a lot

I'd rather stay closer to original xdebug coverage, as we'll probably get back to it in 2.9

Thanks for you work though. I wish I noticed the number before

TomasVotruba added a commit that referenced this pull request Jun 27, 2022
rectorphp/rector-src@9262169 [DX] Move UnionTypeFactory to NodeTypeResolver packages (#2581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants