Skip to content

Transition some travis checks to GithubActions#2589

Merged
TomasVotruba merged 8 commits intorectorphp:masterfrom
staabm:patch-2
Jan 6, 2020
Merged

Transition some travis checks to GithubActions#2589
TomasVotruba merged 8 commits intorectorphp:masterfrom
staabm:patch-2

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Jan 6, 2020

parallize more jobs to speedup the overall CI build time.

In GithubActions we can get up to 8 parallel workers, while on travis its limited to 4.
current overall build time is ~17-18 min. distribution of the jobs should make it faster.

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 6, 2020

@TomasVotruba could you activate GithubActions for this repo?

@TomasVotruba
Copy link
Copy Markdown
Member

I added some file to master. Is that the activation?

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 6, 2020

thx!

hmm I guess I cannot create new githubaction workflows because I am not a repo owner.

just reverted the changes to travis.yml so we could merge this as is and would iterate on the result in a new PR. I guess I can modify a then existing workflow, but creating a new one, as I did here is not allowed as a external collaborateur.

if it works as expected we can drop the travis.yml jobs afterwards.

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 6, 2020

(Alternatively you could take my changes and create a PR yourself)

@TomasVotruba
Copy link
Copy Markdown
Member

I've invited you as a collaborator, so you can can create a branch in here instead of work.

Could you re-check?

@staabm staabm closed this Jan 6, 2020
@staabm staabm reopened this Jan 6, 2020
@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 6, 2020

Thx for the invitation. It seems I dont have permissions to create new branches in this repo

@TomasVotruba
Copy link
Copy Markdown
Member

Let's merge it and see

@TomasVotruba TomasVotruba merged commit 1cfd4bf into rectorphp:master Jan 6, 2020
@staabm staabm deleted the patch-2 branch January 6, 2020 20:58
TomasVotruba added a commit that referenced this pull request Jun 29, 2022
rectorphp/rector-src@87b3ad5 Remove SmartFileInfo registration in bootstrap.php (#2589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants