Remove stubs/ from rector.phar#2609
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Jan 8, 2020
Merged
Conversation
Member
|
Probably this line needs removing too: https://github.com/rectorphp/rector/blob/master/compiler/build/scoper.inc.php#L17 Not sure if phpstorm stubs break your code too, but then PHPStan will be missing them, as it's their dependency. |
Contributor
Author
|
I have no idea how this works... I applied your fix, compiled it and ran it on my project, and it was still working and I had no inspections from PHPStorm anymore. Anything else, I'll ask you to try/fix yourself please, I'm of no use here. |
Member
|
Just remove the other line and see if it still works. Now it's dead code. |
Contributor
Author
|
@TomasVotruba Done, seems to work (at least running the phar on my project). |
Member
|
Thank you! |
Member
|
Possibly useful: #2936 |
TomasVotruba
added a commit
that referenced
this pull request
Jul 2, 2022
rectorphp/rector-src@23bad1e [EarlyReturn] Add ReturnEarlyIfVariableRector (#2609)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2602.