[CountOnNullRector] fix Rector applying on properties with phpdocs array

[gnutix]

Fixes #2474.

[TomasVotruba]

Test case is needed in this PR so CI can verify it

[gnutix]

I couldn't reproduce it within your Fixtures. But I could in my playground repo : gnutix/rector-playground#3 (test is currently failing, but if you merge this in master and restart it, it should pass).

I can't do better than that (tried for hours already), sorry.

[TomasVotruba]

I see.

We should discover the point of origin, since it's probably cause of other related bugs.

[gnutix]

@TomasVotruba I checked the history of the condition I removed before doing the change : it's not used anywhere else, and the test case it was added with passes without this condition (so it was not necessary in the first place apparently - or it was not covered by the test... ?).

So I think there is not much risk of consequences to merge this (but as you wrote this workaround code in the first place, you probably have a better understanding of its scope, so it's up to you).

[TomasVotruba]

So I think there is not much risk of consequences to merge this (

I believe your testing, let's give it a try then.