[AddDoesNotPerformAssertionToNonAssertingTestRector] Add failing test for Prophecy assertions.#2640
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Jan 11, 2020
Conversation
… for Prophecy assertions.
Member
No troubles, I'll handle it. Thank you |
TomasVotruba
deleted the
AddDoesNotPerformAssertionToNonAssertingTestRector/prophecy-failing-test
branch
TomasVotruba
added a commit
that referenced
this pull request
Jul 6, 2022
rectorphp/rector-src@7916cd9 [DX] Remove doctrine collection responsibility to TypedPropertyRector (#2640)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a failing test case for this (currently it adds the annotation to the method yet it should not).
However, I'm not interested in implementing a fix myself, as it's ignored from my project anyway and I already wasted way too much time on this one : I'd rather focus on other issues (or take a break 😄 ). I could upgrade this Rector's documentation to state that it currently does not support Prophecy and any help in implementing it is welcome though.