Skip to content

use Github Actions to compiler and publish prefixed rector.phar#2641

Merged
TomasVotruba merged 1 commit intomasterfrom
github-actions
Jan 11, 2020
Merged

use Github Actions to compiler and publish prefixed rector.phar#2641
TomasVotruba merged 1 commit intomasterfrom
github-actions

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the github-actions branch 4 times, most recently from 1a89378 to f6a5572 Compare January 11, 2020 15:30
@TomasVotruba TomasVotruba merged commit 9960874 into master Jan 11, 2020
@TomasVotruba TomasVotruba deleted the github-actions branch January 11, 2020 15:39
@TomasVotruba TomasVotruba requested a review from staabm January 11, 2020 15:44
@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented Jan 11, 2020

@staabm Hey, thanks for bringing Github Actions here 👏 . I finished the migration with this PR, feel free to post-review and improve if further. I'm still newbie in it. I took a week to study it all and convert all repositories there.


We got from 12 minutes down to 3 on CI feedback loop:

https://twitter.com/rectorphp/status/1216022792266833920

That's so crazy 😍 🙉

@staabm
Copy link
Copy Markdown
Contributor

staabm commented Jan 12, 2020

Looks good to me. Great job!

TomasVotruba added a commit that referenced this pull request Jul 8, 2022
rectorphp/rector-src@bf92b9c [DeadCode] Skip global and static variable on RemoveJustVariableAssignRector (#2641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants