Skip to content

Rename --rule argument into --only, add documentation.#2655

Merged
TomasVotruba merged 5 commits intorectorphp:masterfrom
gnutix:filter-rector
Jan 14, 2020
Merged

Rename --rule argument into --only, add documentation.#2655
TomasVotruba merged 5 commits intorectorphp:masterfrom
gnutix:filter-rector

Conversation

@gnutix
Copy link
Copy Markdown
Contributor

@gnutix gnutix commented Jan 13, 2020

Fixes #2651.

@stloyd
Copy link
Copy Markdown
Contributor

stloyd commented Jan 13, 2020

That name sound a bit confusing, what about --use-only?

@TomasVotruba
Copy link
Copy Markdown
Member

Good point! Maybe --only-rule would be better, as the value should be Rector rule

@gnutix
Copy link
Copy Markdown
Contributor Author

gnutix commented Jan 13, 2020

Is it a "rule" or a "rector" ? I think that should be clear and coherent everywhere. Filter or only, I don't mind.

@TomasVotruba
Copy link
Copy Markdown
Member

In that case --only might be the best solution
It's used on ECS in similar way

@gnutix gnutix changed the title Rename --rule argument into --filter-rector, add documentation. Rename --rule argument into --only, add documentation. Jan 14, 2020
@gnutix gnutix requested a review from TomasVotruba January 14, 2020 19:56
@gnutix
Copy link
Copy Markdown
Contributor Author

gnutix commented Jan 14, 2020

Done!

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jan 14, 2020

Feature is ok 👍
CI should be fixed though

@gnutix
Copy link
Copy Markdown
Contributor Author

gnutix commented Jan 14, 2020

Done!

Comment thread README.md Outdated
Comment thread README.md Outdated
@gnutix gnutix requested a review from TomasVotruba January 14, 2020 20:46
@TomasVotruba TomasVotruba merged commit a32dae4 into rectorphp:master Jan 14, 2020
@TomasVotruba TomasVotruba deleted the filter-rector branch January 14, 2020 21:00
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--rule is not working as I expected

3 participants