Introduce a CallReflectionResolver#2658
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Jan 14, 2020
Lctrs:call-reflection-resolver
Merged
Introduce a CallReflectionResolver#2658TomasVotruba merged 1 commit intorectorphp:masterfrom Lctrs:call-reflection-resolver
TomasVotruba merged 1 commit intorectorphp:masterfrom
Lctrs:call-reflection-resolver
Conversation
Member
|
Could elaborate on motivation and main features for this PR? |
Contributor
Author
|
Main motivation was to reduce duplicated code and leverage PHPStan to create a class that is able to return the reflected function from any calls given, even on a variable that has been assigned a closure (eg. |
Member
|
I see, thanks 👍 |
Contributor
Author
|
Worth noting that |
Member
|
Go for it |
TomasVotruba
added a commit
that referenced
this pull request
Jul 13, 2022
rectorphp/rector-src@ae7648e [CodingStyle] Add StaticClosureRector (#2658)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.