Skip to content

Changed ChangeMethodVisibilityRector yaml config#2687

Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom
C0pyR1ght:patch-3
Jan 17, 2020
Merged

Changed ChangeMethodVisibilityRector yaml config#2687
TomasVotruba merged 2 commits intorectorphp:masterfrom
C0pyR1ght:patch-3

Conversation

@C0pyR1ght
Copy link
Copy Markdown
Contributor

The example config resulted in an invalid yaml file with the current rector version.
The configuration key "FrameworkClass" is unsupported for definition

The example config resulted in an invalid yaml file with the current rector version.
´The configuration key "FrameworkClass" is unsupported for definition`
FrameworkClass:
$methodToVisibilityByClass:
FrameworkClass:
someMethod: protected
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated from ChangeMethodVisibilityRector. This needs to be fixed in getRectorDefinition() method there

@TomasVotruba TomasVotruba merged commit c375caf into rectorphp:master Jan 17, 2020
TomasVotruba added a commit that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants