Merge pull request #2702 from rectorphp/dx-get-node-types

config/services.yaml

@@ -23,7 +23,6 @@ services:
         alias: 'Rector\Console\Application'
 
     Symfony\Component\Console\Descriptor\TextDescriptor: null
-    Symfony\Component\Process\PhpExecutableFinder: null
 
     # PhpParser - Parser
     PhpParser\ParserFactory: null

src/Console/Command/ProcessCommand.php

@@ -15,7 +15,6 @@
 use Rector\Extension\ReportingExtensionRunner;
 use Rector\FileSystem\FilesFinder;
 use Rector\Guard\RectorGuard;
-use Rector\Linter\Linter;
 use Rector\PhpParser\NodeTraverser\RectorNodeTraverser;
 use Rector\Stubs\StubLoader;
 use Symfony\Component\Console\Input\InputArgument;
@@ -86,11 +85,6 @@ final class ProcessCommand extends AbstractCommand
      */
     private $paths = [];
 
-    /**
-     * @var Linter
-     */
-    private $linter;
-
     /**
      * @param string[] $paths
      * @param string[] $fileExtensions
@@ -106,7 +100,6 @@ public function __construct(
         ReportingExtensionRunner $reportingExtensionRunner,
         RectorNodeTraverser $rectorNodeTraverser,
         StubLoader $stubLoader,
-        Linter $linter,
         array $paths,
         array $fileExtensions
     ) {
@@ -122,7 +115,6 @@ public function __construct(
         $this->rectorNodeTraverser = $rectorNodeTraverser;
         $this->stubLoader = $stubLoader;
         $this->paths = $paths;
-        $this->linter = $linter;
 
         parent::__construct();
     }
@@ -201,6 +193,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $this->configuration->setAreAnyPhpRectorsLoaded((bool) $this->rectorNodeTraverser->getPhpRectorCount());
 
         $this->rectorGuard->ensureSomeRectorsAreRegistered();
+        $this->rectorGuard->ensureGetNodeTypesAreNodes();
         $this->stubLoader->loadStubs();
 
         $source = $this->resolvesSourcePaths($input);
@@ -211,10 +204,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->configuration->mustMatchGitDiff()
         );
 
-        foreach ($phpFileInfos as $phpFileInfo) {
-            $this->linter->lintFile($phpFileInfo);
-        }
-
         $this->additionalAutoloader->autoloadWithInputAndSource($input, $source);
 
         $this->rectorApplication->runOnFileInfos($phpFileInfos);

src/Exception/Rector/InvalidRectorException.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Exception\Rector;
+
+use Exception;
+
+final class InvalidRectorException extends Exception
+{
+}

src/Guard/RectorGuard.php

@@ -4,7 +4,9 @@
 
 namespace Rector\Guard;
 
+use PhpParser\Node;
 use Rector\Exception\NoRectorsLoadedException;
+use Rector\Exception\Rector\InvalidRectorException;
 use Rector\FileSystemRector\FileSystemFileProcessor;
 use Rector\PhpParser\NodeTraverser\RectorNodeTraverser;
 
@@ -45,4 +47,22 @@ public function ensureSomeRectorsAreRegistered(): void
             PHP_EOL
         ));
     }
+
+    public function ensureGetNodeTypesAreNodes(): void
+    {
+        foreach ($this->rectorNodeTraverser->getAllPhpRectors() as $phpRector) {
+            foreach ($phpRector->getNodeTypes() as $nodeTypeClass) {
+                if (is_a($nodeTypeClass, Node::class, true)) {
+                    continue;
+                }
+
+                throw new InvalidRectorException(sprintf(
+                    'Method "%s::getNodeTypes() provides invalid node class "%s". It must be child of "%s"',
+                    get_class($phpRector),
+                    $nodeTypeClass,
+                    Node::class
+                ));
+            }
+        }
+    }
 }