Merged
Conversation
zonuexe
force-pushed
the
feature/setcookie-rector
branch
from
85636fd to
1a557e0
Compare
Member
|
CI needs fixing |
zonuexe
force-pushed
the
feature/setcookie-rector
branch
from
531cc6c to
2b29ce7
Compare
zonuexe
force-pushed
the
feature/setcookie-rector
branch
from
2b29ce7 to
d6effd6
Compare
Contributor
Author
|
@TomasVotruba I rebase on master and fixed them. |
TomasVotruba
approved these changes
Jan 21, 2020
Member
|
Looks good, thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Jul 25, 2022
rectorphp/rector-src@bd4a732 doc: fix visibility should not change (#2711)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert to
setcookie()options array introduced in PHP 7.3.This Rector just breaks backward compatibility with less than PHP 7.3 since PHP 7.3 actually supports old arguments. However, since the option array is required to set the
samesiteattribute, the changes are highlighted.