Decouple PHPStan Type to function resolver logic#2742
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Feb 10, 2020
Lctrs:decouple
Merged
Decouple PHPStan Type to function resolver logic#2742TomasVotruba merged 1 commit intorectorphp:masterfrom Lctrs:decouple
TomasVotruba merged 1 commit intorectorphp:masterfrom
Lctrs:decouple
Conversation
Member
|
Any update on this? Looks like stale |
Contributor
Author
|
Yeah sorry. Didn't had much time lately. Will try to finish this tomorrow. |
Contributor
Author
|
@TomasVotruba Done. |
TomasVotruba
reviewed
Feb 7, 2020
| /** | ||
| * @param ClosureType $type | ||
| */ | ||
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer) |
Member
There was a problem hiding this comment.
There should be return type, in interface and it's implementations
| /** | ||
| * @param ClosureType $type | ||
| */ | ||
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer) |
Member
There was a problem hiding this comment.
There should be return type, in interface and it's implementations
| /** | ||
| * @return FunctionReflection|MethodReflection|null | ||
| */ | ||
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer); |
Member
There was a problem hiding this comment.
Suggested change
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer); | |
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer): ?\ReflectionFunctionAbstract` |
Contributor
Author
There was a problem hiding this comment.
Won't work. We're not returning a core reflection instance, but an instance of PHPStan's reflection (or null). A return type is not possible here.
Member
There was a problem hiding this comment.
Do they have any common parent?
Contributor
Author
There was a problem hiding this comment.
I checked and no. FunctionReflection and MethodReflection are two independant interfaces.
| /** | ||
| * @return FunctionReflection|MethodReflection|null | ||
| */ | ||
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer) |
Member
There was a problem hiding this comment.
Suggested change
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer) | |
| public function resolve(Type $type, ClassMemberAccessAnswerer $classMemberAccessAnswerer): ?\ReflectionFunctionAbstract |
Member
|
CI needs fixing |
Contributor
Author
|
@TomasVotruba It's green 🎉 |
TomasVotruba
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.