Skip to content

misc #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Jan 28, 2020
Merged

misc #2772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c15ec
misc
TomasVotruba Jan 28, 2020
5afed89
decouple FunctionToServiceMap
TomasVotruba Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/CodeQuality/src/Rector/If_/ExplicitBoolCompareRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\Cast\Bool_;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Ternary;
use PhpParser\Node\Scalar\DNumber;
Expand Down Expand Up @@ -90,7 +91,7 @@ public function refactor(Node $node): ?Node
$isNegated = false;
}

if ($conditionNode instanceof Expr\Cast\Bool_) {
if ($conditionNode instanceof Bool_) {
return null;
}

Expand Down
10 changes: 10 additions & 0 deletions packages/Laravel/config/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
services:
_defaults:
public: true
autowire: true

Rector\Laravel\:
resource: '../src'
exclude:
- '../src/Rector/**/*Rector.php'
- '../src/ValueObject/*'
174 changes: 174 additions & 0 deletions packages/Laravel/src/FunctionToServiceMap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
<?php

declare(strict_types=1);

namespace Rector\Laravel;

use Rector\Laravel\ValueObject\ArrayFunctionToMethodCall;
use Rector\Laravel\ValueObject\FunctionToMethodCall;

final class FunctionToServiceMap
{
/**
* @var FunctionToMethodCall[]
*/
public $functionToMethodCalls = [];

/**
* @var ArrayFunctionToMethodCall[]
*/
private $arrayFunctionToMethodCalls = [];

public function __construct()
{
$this->initFunctionToMethodCalls();
$this->initArrayFunctionToMethodCalls();
}

/**
* @return FunctionToMethodCall|ArrayFunctionToMethodCall|null
*/
public function findByFunction(string $functionName): ?object
{
foreach ($this->functionToMethodCalls as $functionToMethodCall) {
if ($functionToMethodCall->getFunction() !== $functionName) {
continue;
}

return $functionToMethodCall;
}

foreach ($this->arrayFunctionToMethodCalls as $arrayFunctionToMethodCall) {
if ($arrayFunctionToMethodCall->getFunction() !== $functionName) {
continue;
}

return $arrayFunctionToMethodCall;
}

return null;
}

private function initArrayFunctionToMethodCalls(): void
{
$this->arrayFunctionToMethodCalls[] = new ArrayFunctionToMethodCall(
'config',
'Illuminate\Contracts\Config\Repository',
'configRepository',
'set',
'get'
);

$this->arrayFunctionToMethodCalls[] = new ArrayFunctionToMethodCall(
'session',
'Illuminate\Session\SessionManager',
'sessionManager',
'put',
'get'
);
}

private function initFunctionToMethodCalls(): void
{
$this->functionToMethodCalls[] = new FunctionToMethodCall(
'auth', 'Illuminate\Contracts\Auth\Guard', 'guard'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'policy', 'Illuminate\Contracts\Auth\Access\Gate', 'policy', 'getPolicyFor'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'cookie', 'Illuminate\Contracts\Cookie\Factory', 'cookieFactory', 'make'
);

// router
$this->functionToMethodCalls[] = new FunctionToMethodCall(
'put', 'Illuminate\Routing\Router', 'router', 'put'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'get', 'Illuminate\Routing\Router', 'router', 'get'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'post', 'Illuminate\Routing\Router', 'router', 'post'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'patch', 'Illuminate\Routing\Router', 'router', 'patch'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'delete', 'Illuminate\Routing\Router', 'router', 'delete'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'resource', 'Illuminate\Routing\Router', 'router', 'resource'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'response', 'Illuminate\Contracts\Routing\ResponseFactory', 'responseFactory', 'make'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'info', 'Illuminate\Log\Writer', 'logWriter', 'info'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'view', 'Illuminate\Contracts\View\Factory', 'viewFactory', 'make'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'bcrypt', 'Illuminate\Hashing\BcryptHasher', 'bcryptHasher', 'make'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'redirect', 'Illuminate\Routing\Redirector', 'redirector', 'back'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'broadcast', 'Illuminate\Contracts\Broadcasting\Factory', 'broadcastFactory', 'event'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'event', 'Illuminate\Events\Dispatcher', 'eventDispatcher', 'fire'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'dispatch', 'Illuminate\Events\Dispatcher', 'eventDispatcher', 'dispatch'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'route', 'Illuminate\Routing\UrlGenerator', 'urlGenerator', 'route'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'asset', 'Illuminate\Routing\UrlGenerator', 'urlGenerator', 'asset'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'url', 'Illuminate\Contracts\Routing\UrlGenerator', 'urlGenerator', 'to'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'action', 'Illuminate\Routing\UrlGenerator', 'urlGenerator', 'action'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'trans', 'Illuminate\Translation\Translator', 'translator', 'trans'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'trans_choice', 'Illuminate\Translation\Translator', 'translator', 'transChoice'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'logger', 'Illuminate\Log\Writer', 'logWriter', 'debug'
);

$this->functionToMethodCalls[] = new FunctionToMethodCall(
'back', 'Illuminate\Routing\Redirector', 'redirector', 'back', 'back'
);
}
}
Loading