Skip to content

Cognitive complexity fixes#2819

Merged
TomasVotruba merged 1 commit intomasterfrom
ecs-fixes
Feb 9, 2020
Merged

Cognitive complexity fixes#2819
TomasVotruba merged 1 commit intomasterfrom
ecs-fixes

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the ecs-fixes branch 2 times, most recently from ffe22e1 to 62a3551 Compare February 9, 2020 20:52
@TomasVotruba TomasVotruba changed the title [WIP] Cognitive complexity fixes Cognitive complexity fixes Feb 9, 2020
@TomasVotruba TomasVotruba force-pushed the ecs-fixes branch 3 times, most recently from 03c42b8 to 7d4e322 Compare February 9, 2020 21:53
@TomasVotruba
Copy link
Copy Markdown
Member Author

cs2pr was disabled, because it failed PHPStan build

- run: composer install --no-progress
# turn the phpstan errors (formatted in checkstyle-format) into github pull request check annotations
- run: composer phpstan -- --error-format=checkstyle | cs2pr
- run: composer phpstan # -- --error-format=checkstyle | cs2pr
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled because it kept breaking the builds

@TomasVotruba TomasVotruba merged commit e3b2067 into master Feb 9, 2020
@TomasVotruba TomasVotruba deleted the ecs-fixes branch February 9, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant