Inject the coveralls token as a secret#2840
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Feb 13, 2020
Merged
Conversation
Member
|
I miss reasoning. |
Contributor
Author
|
From Coveralls documentation:
I think anyone could send fake coveralls report on behalf of the repository or do some nasty things + it promotes a bad practice, someone might think it is a good idea to put a token into a configuration file and will put something more serious there, which is a big no-no. |
Member
|
Better, thanks. Its always better to see why the change, rather than what has changed. Often people try to work around some bug that should be fixed in the first place. |
Member
|
Thank you Ivan! |
Member
|
I tried to rebuild the token + update secrets and it works for now. Let's see how it goes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COVERALLS_REPO_TOKENvariable in GitHub Actions Settings in the repository.