Skip to content

Inject the coveralls token as a secret#2840

Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom
ikvasnica:patch-1
Feb 13, 2020
Merged

Inject the coveralls token as a secret#2840
TomasVotruba merged 1 commit intorectorphp:masterfrom
ikvasnica:patch-1

Conversation

@ikvasnica
Copy link
Copy Markdown
Contributor

  1. Replace the Coveralls repo token in YAML with an environment variable.
  2. Re-generate the token in Coveralls settings, since this one is already leaked online.
  3. TODO: Set the new token as a COVERALLS_REPO_TOKEN variable in GitHub Actions Settings in the repository.

@TomasVotruba
Copy link
Copy Markdown
Member

I miss reasoning.
What can be changed with the token?

@ikvasnica
Copy link
Copy Markdown
Contributor Author

From Coveralls documentation:

repo_token String
The secret repo token for your repository

I think anyone could send fake coveralls report on behalf of the repository or do some nasty things + it promotes a bad practice, someone might think it is a good idea to put a token into a configuration file and will put something more serious there, which is a big no-no.

@TomasVotruba
Copy link
Copy Markdown
Member

Better, thanks. Its always better to see why the change, rather than what has changed.

Often people try to work around some bug that should be fixed in the first place.

@TomasVotruba TomasVotruba merged commit 351c2dc into rectorphp:master Feb 13, 2020
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you Ivan!

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Feb 13, 2020

I tried to rebuild the token + update secrets and it works for now. Let's see how it goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants