Improve AnnotateThrowablesRector#2857
Merged
TomasVotruba merged 2 commits intomasterfrom Feb 14, 2020
Merged
Conversation
TomasVotruba
force-pushed
the
fix-throws
branch
3 times, most recently
from
43e0693 to
1c00e31
Compare
TomasVotruba
force-pushed
the
fix-throws
branch
from
1c00e31 to
401d0ae
Compare
Member
Author
|
@Aerendir Just FIY, I've added few improvements to save the code and use Rector conventions. Mostly 2nd commits is important. Be sure to use PHPStan and ECS right from the start next time. There were lot of classes with wrong namespaces, that took time to discover |
Contributor
|
It was no t ready to be merged evidently :( |
Member
Author
|
It was acceptable. Coding is never-ending improvement :) |
TomasVotruba
added a commit
that referenced
this pull request
Aug 30, 2022
rectorphp/rector-src@cf65fca Add rector-debugging to require-dev (#2857)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2833