Make AnnotateThrowablesRector continue on unhandled node types.#2860
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Feb 16, 2020
Aerendir:make-annotate-throwables-continue-on-variable
Merged
Make AnnotateThrowablesRector continue on unhandled node types.#2860TomasVotruba merged 1 commit intorectorphp:masterfrom Aerendir:make-annotate-throwables-continue-on-variable
AnnotateThrowablesRector continue on unhandled node types.#2860TomasVotruba merged 1 commit intorectorphp:masterfrom
Aerendir:make-annotate-throwables-continue-on-variable
Conversation
Contributor
Author
|
The branch is based on commit fcec6e3 and anyway fails 😓 |
Member
|
There is problem with code coverage only, skip it |
Contributor
Author
|
Ok, then it is ready to merge. I simply removed two throws and returned a value anyway. This way the rector doesn’t stop (it was for dev purposes only) and continues its work. Later I will start implementing the other node types... There is the problem of accessing the called function/method doc block, but I will describe the problem extensively in another issue/PR. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.