Skip to content

Adding failing test for RemoveAlwaysElseRector#2862

Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom
escopecz:remove-always-elase-anonymous-function
Feb 16, 2020
Merged

Adding failing test for RemoveAlwaysElseRector#2862
TomasVotruba merged 2 commits intorectorphp:masterfrom
escopecz:remove-always-elase-anonymous-function

Conversation

@escopecz
Copy link
Copy Markdown
Contributor

With a foreach within an anonymous function.

Issue: #2842

With a foreach within an anonymous function
@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Feb 16, 2020

Better add new file e.g. foreach_anonymous_function.php.inc, to keep complexity low.
File with 50 cases is hell to debug and keep working

@escopecz
Copy link
Copy Markdown
Contributor Author

@TomasVotruba good now?

@TomasVotruba TomasVotruba merged commit 6554782 into rectorphp:master Feb 16, 2020
@TomasVotruba
Copy link
Copy Markdown
Member

Great, thanks!

@escopecz escopecz deleted the remove-always-elase-anonymous-function branch February 17, 2020 08:06
TomasVotruba added a commit that referenced this pull request Aug 30, 2022
rectorphp/rector-src@b01ea04 [DX] Make use of FilePathHelper over inner magic of FileSystem in SmartFileInfo (#2862)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants