AnnotateThrowablesRector: Improve organization of tests.#2876
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Feb 18, 2020
Aerendir:AnnotateThrowables-improve-tests-organization
Merged
AnnotateThrowablesRector: Improve organization of tests.#2876TomasVotruba merged 2 commits intorectorphp:masterfrom Aerendir:AnnotateThrowables-improve-tests-organization
AnnotateThrowablesRector: Improve organization of tests.#2876TomasVotruba merged 2 commits intorectorphp:masterfrom
Aerendir:AnnotateThrowables-improve-tests-organization
Conversation
Contributor
Author
|
@TomasVotruba , to avoid having a big feature branch, I'm PRing this to prepare the work in small chunks and trying to maintain the feature branches as updated with This PR is ready to be merged if you like... |
Member
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a dedicated class for
ExceptionsFactoryStaticMethodWithReturnDocblockso the inspection of node tree is less prone to errors in finding paths.Prepare to solve #2861 .